The return value of dentry_open() shoud be checked by IS_ERR(). Cc: Stephen Smalley <[EMAIL PROTECTED]> Cc: James Morris <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]>
--- security/selinux/hooks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: work-fault-inject/security/selinux/hooks.c =================================================================== --- work-fault-inject.orig/security/selinux/hooks.c +++ work-fault-inject/security/selinux/hooks.c @@ -1760,7 +1760,8 @@ static inline void flush_unauthorized_fi get_file(devnull); } else { devnull = dentry_open(dget(selinux_null), mntget(selinuxfs_mount), O_RDWR); - if (!devnull) { + if (IS_ERR(devnull)) { + devnull = NULL; put_unused_fd(fd); fput(file); continue; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/