Mason <[email protected]> writes: > Hello Mans, > > On 29/09/2015 22:18, Måns Rullgård wrote: > >> Mason writes: >> >>> On 29/09/2015 20:32, Thomas Gleixner wrote: >>> >>>> On Tue, 29 Sep 2015, Mason wrote: >>>> >>>>> I am trying to submit a new ARM port, and Arnd pointed out that the >>>>> clocksource code could not live in arch/arm/$PLATFORM, but had to >>>>> move to drivers/clocksource (and it had to support DT). >>>>> >>>>> Did I understand correctly? Is this the right place to submit code >>>>> as provided below? >>>> >>>> Yes, drivers/clocksource is the right place. You just need to submit a >>>> formal patch, which includes a proper subject line, changelog, plus >>>> the necessary Makefile and Kconfig modifications. >>> >>> OK, I'll send a formal patch tomorrow. >>> There are no Kconfig modifications, is that OK? >> >> Why don't you use my driver? It's even simpler, and it works just fine >> on the 87xx chip. >> >> https://github.com/mansr/linux-tangox/blob/master/drivers/clocksource/clksrc-tangox.c > > As you know, I am using two of your complex drivers, namely > ethernet and interrupt controller (which would have taken me > several weeks to write). I will be submitting them upstream > shortly, is that OK with you?
I want to test them a bit more on the 87xx first. It's booting, but there are a couple of niggles that should be looked into. Getting some documentation would expedite that process. > I'm not using this particular driver of yours because I had > already written the code, and porting it to DT was a good > learning process. This is probably my only opportunity to > actually write any kind of code for this port. You should still be using the existing clocksource_mmio helper. In fact, that interface could be exposed using a generic DT binding. -- Måns Rullgård [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
