>-----Original Message----- >From: Sudeep Holla [mailto:[email protected]] >Sent: Monday, September 21, 2015 6:47 PM >To: [email protected]; [email protected] >Cc: Sudeep Holla <[email protected]>; Thomas Gleixner ><[email protected]>; Rafael J. Wysocki <[email protected]>; David S. Miller ><[email protected]>; Manoil Claudiu-B08782 ><[email protected]>; Kevin Hao <[email protected]>; >[email protected] >Subject: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND >flag > >The device is set as wakeup capable using proper wakeup API but the >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source >which is incorrect. > >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >enable_irq_wake instead. >
What would be the purpose of IRQF_NO_SUSPEND flag then? The flag is a friendlier API compared to calling enable_irq_wake(). For older kernels, on PPC architectures, the flag did the job. When did this change? Since when using IRQF_NO_SUSPEND is a "misuse"? Thanks, Claudiu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
