On Sun, 20 Sep 2015, Marc Zyngier wrote:
> > Uff... in one of earliest reviews i was asked to add lock..
> > I also was asked to add asm9260 to some existing driver. Not sure if it
> > is still making sense.
>
> Adding or removing a lock is not about what people ask you to do. It is
> about requirements dictated by either the HW (you need to perform
> a given sequence atomically with respect to another code sequence), the
> kernel, or both. So I'd like to understand what is the underlying
> reason for this lock. It is not disabling interrupts, so it could end
> up being called in an interrupt context -> deadlock.
The callback is always called with interrupts disabled, so that's a
non issue. But still, the rationale for that lock is unclear.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
