On Wednesday, September 16, 2015 04:48:37 AM Rafael J. Wysocki wrote:
> On Wednesday, September 16, 2015 07:30:23 AM Viresh Kumar wrote:
> > On 16-09-15, 03:43, Rafael J. Wysocki wrote:
> > > On Tuesday, September 15, 2015 01:42:21 PM Viresh Kumar wrote:
> > > > The variable 'wakeup_irq' is defined within #ifdef CONFIG_PM_SLEEP_DEBUG
> > > > and used outside of it. And that breaks kernel build:
> > > >
> > > > /home/viresh/linux/drivers/base/power/wakeup.c:871: undefined reference
> > > > to `wakeup_irq'
> > > > /home/viresh/drivers/base/power/wakeup.c:871: undefined reference to
> > > > `wakeup_irq'
> > > >
> > > > Fix it by defining the variable outside of the ifdef.
> > > >
> > > > Fixes: d1e59c235322 ("PM / sleep: Report interrupt that caused system
> > > > wakeup")
> > > > Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org>
> > >
> > > I've applied the v11 of the Alexandra's patch that doesn't have this
> > > problem AFAICS.
> >
> > For the record, as we have talked on IRC, even the v11 patch suffers
> > from this problem and you will be fixing it.
>
> Yes, it was slightly messed up. Should be better now, though.
And as a side note, for patches that are in bleeding-edge only and not in
something like linux-next, you don't need to bother anyone with fixes except
for me (and maybe the patch author for their education mostly).
And I either drop patches that cause build problems to happen in bleeding-edge
or fix them. That's what bleeding-edge is for.
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
