On Sat, 2015-09-12 at 01:11 +0000, Rustad, Mark D wrote:
> Alex,
>
> > On Sep 11, 2015, at 11:16 AM, Alex Williamson <alex.william...@redhat.com>
> > wrote:
> >
> > RFC - Is this something we should do?
>
> Superficially this looks pretty good. I need to think harder to be sure of
> the details.
>
> > Should we consider providing
> > similar emulation through PCI sysfs to allow lspci to also make use
> > of the vpd interfaces?
>
> It looks to me like lspci already uses the vpd attribute in sysfs to access
> VPD, so maybe nothing more than this is needed. No doubt lspci can be coerced
> into accessing VPD directly, but is that really worth going after? I'm not so
> sure.
>
> An strace of lspci accessing a device with VPD shows me:
>
> write(1, "\tCapabilities: [e0] Vital Produc"..., 39 Capabilities: [e0]
> Vital Product Data
> ) = 39
> open("/sys/bus/pci/devices/0000:02:00.0/vpd", O_RDONLY) = 4
> ----------------------------------------^^^ accesses to this should be safe,
> I think
>
> pread(4, "\202", 1, 0) = 1
> pread(4, "\10\0", 2, 1) = 2
> pread(4, "PVL Dell", 8, 3) = 8
> write(1, "\t\tProduct Name: PVL Dell\n", 25 Product Name: PVL Dell
> ) = 25
>
> and so forth.
Oh good, so aside from some rouge admin poking around with setpci access
through pci-sysfs is hopefully not an issue. Thanks for looking into
it.
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
