Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>

Signed-off-by: Julia Lawall <julia.law...@lip6.fr>

---
 fs/gfs2/main.c |   29 +++++++----------------------
 1 file changed, 7 insertions(+), 22 deletions(-)

diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 241a399..4d78c3e 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -192,28 +192,13 @@ fail:
 fail_lru:
        unregister_shrinker(&gfs2_qd_shrinker);
        gfs2_glock_exit();
-
-       if (gfs2_rsrv_cachep)
-               kmem_cache_destroy(gfs2_rsrv_cachep);
-
-       if (gfs2_quotad_cachep)
-               kmem_cache_destroy(gfs2_quotad_cachep);
-
-       if (gfs2_rgrpd_cachep)
-               kmem_cache_destroy(gfs2_rgrpd_cachep);
-
-       if (gfs2_bufdata_cachep)
-               kmem_cache_destroy(gfs2_bufdata_cachep);
-
-       if (gfs2_inode_cachep)
-               kmem_cache_destroy(gfs2_inode_cachep);
-
-       if (gfs2_glock_aspace_cachep)
-               kmem_cache_destroy(gfs2_glock_aspace_cachep);
-
-       if (gfs2_glock_cachep)
-               kmem_cache_destroy(gfs2_glock_cachep);
-
+       kmem_cache_destroy(gfs2_rsrv_cachep);
+       kmem_cache_destroy(gfs2_quotad_cachep);
+       kmem_cache_destroy(gfs2_rgrpd_cachep);
+       kmem_cache_destroy(gfs2_bufdata_cachep);
+       kmem_cache_destroy(gfs2_inode_cachep);
+       kmem_cache_destroy(gfs2_glock_aspace_cachep);
+       kmem_cache_destroy(gfs2_glock_cachep);
        gfs2_sys_uninit();
        return error;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to