On Thu, Sep 10, 2015 at 05:24:58PM +0530, Sudip Mukherjee wrote: > The return pointer from dgap_getword() is used in strcmp() where it is > dereferenced. But dgap_getword() can return NULL. > Lets put a check there and return 0 as error. > > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> > --- > drivers/staging/dgap/dgap.c | 2 ++ > 1 file changed, 2 insertions(+)
While this change is all nice and fine, this driver is totally abusing the firmware kernel interface to read in a "configuration file" and then parse it within the driver. That's not ok at all, no tty driver should ever need this. Please work to just rip all of that crap out. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
