On Wed, Sep 09, 2015 at 06:43:11PM +1000, Michael Ellerman wrote: > On Tue, 2015-09-08 at 16:34 +0200, Andrea Arcangeli wrote: > > > > I already had a few minor changes queued to be submitted for arm and > > ppc and a few updates to the selftest. > > > > I didn't like that you had to remember running make headers_install > > for changes like the below one to build, so I added the dependency so > > that "make" still works without having to run other commands before > > it. These aren't reviewed yet. > > > > https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=5ce2efeb91b501aa1bc7370f43732681fa9123e2 > > That's, how should I put it, fairly gross :) > > I'd really rather you didn't do that. It's really not that hard to run make > headers_install once manually is it?
I agree it's fairly gross, but I don't like when "make" fails and you need to know something non-standard from documentation to make it work (ehm documentation? I don't think there is any about how to build the selftest). This is self documenting change (that works better than actual documentation) and you're free to run "make headers_install" by hand if you prefer after a git clean -d -x -f and you won't know the difference. If there's a cleaner solution that's fine, but I don't like to fallback in having to run "make headers_install" by hand :). > I think given you already have a series you should pick this up as part of > that series. It will need to be reworked slightly anyway to go on top of your > series I think. Yep I reworked and integrated it. Thanks! Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
