On Thu, Sep 08, 2005 at 05:47:38PM +0200, Bartlomiej Zolnierkiewicz wrote: > On 9/8/05, Tom Rini <[EMAIL PROTECTED]> wrote: > > In some cases (such as the mips Toshiba TX4939 w/ onboard IDE, not PCI > > IDE), hwif->cds can be NULL, so test that prior to testing > > hwif->cds->foo > > Both ide_iomio_dma() and ide_mapped_mmio_dma() are only called from > ide_dma_iobase(). ide_setup_dma() is the only user of ide_dma_iobase() > and it is supposed to be used only by IDE PCI drivers. > > What is the reason for this change?
I'll try and explain for Hiroshi DOYU, but the IDE driver for the tx4939 (overall port still need a little bit more review before being sent to linux-mips, so the ide driver hasn't been submitted yet either) calls ide_setup_dma(), and has hwif->cds == NULL. -- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
