On Wed, Sep 07, 2005 at 06:09:10PM +0100, Alan Cox wrote: > On Maw, 2005-09-06 at 16:33 -0700, Ravikiran G Thirumalai wrote: > > 2. Change the core ide code to use hwgroup->lock instead of ide_lock. > > Deprecate ide_lock (patch 2) > > hwgroups and IDE locking requirements are frequently completely > unrelated. Its clear from the changes proposed you've not tested on real > hardware for each case and you have not studied the documented errata
I tested it on a 2way box with a piix controller. It got through Bonnie++. I have access to piix controllers only, so that was the only controller I changed. I did not read the errata though... :( Do you think the approach is unsafe, even if the piix tune routine is serialized with a per-driver lock? Bartlomiej? Thanks, Kiran - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
