On Mon, Aug 31, 2015 at 01:20:31PM +0100, Marc Zyngier wrote: > On Sun, 30 Aug 2015 21:15:56 +0800 > Hanjun Guo <hanjun....@linaro.org> wrote: > > I agree. In arch/arm64/kernel/irq.c the irq migrate code is the same > > as ARM32, and it's duplicate. But this is a bugfix, can we fix it in > > a simple way, and refactor the code later? > > I'm not buying this. > > I really can't see how adding more duplication can be beneficial. It is > not so much that there is duplication between arm and arm64 that > bothers me (as if that was the only thing...). The real issue is that > there is duplication between the arch code and the core code. > > Migrating interrupts is a core code matter, and that's were it should > be handled IMHO. Plus, we're in the merge window, and there is plenty > of time to get this fixed the proper way.
Yup. I suggested this over a year ago but not sure why nothing happened: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266923.html Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
