On Fri, Aug 28, 2015 at 02:20:52PM +0100, Matt Fleming wrote: > On Wed, 26 Aug, at 03:46:51PM, Jiri Olsa wrote: > > Pass 'struct parse_events_error *error' to the parse-event.c > > tracepoint adding path. It will be filled with error data > > in following patches. > > > > Link: http://lkml.kernel.org/n/tip-las1hm5zf58b0twd27h98...@git.kernel.org > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > > --- > > tools/perf/util/parse-events.c | 27 ++++++++++++++++----------- > > tools/perf/util/parse-events.h | 3 ++- > > tools/perf/util/parse-events.y | 4 ++-- > > 3 files changed, 20 insertions(+), 14 deletions(-) > > Is there a reason you decided to go ahead with passing 'data->error' > directly to the parsing functions instead of adding some global state > for recording errors, like a globally accessible 'parse_events_error'? > > Because I notice that if someone wanted to improve the breakpoint > parsing code, they'd basically need to make the same changes you've > made in this patch.
well, I dont see much benefit other than loosing one extra arg and worrying about concurent access in the future.. but I might have missed some jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
