On Thu, 2015-08-27 at 09:09 +0200, Nicolas Morey Chaisemartin wrote:
> > From: "Joe Perches" <[email protected]>
[]
> > And because most likely, "CONST test variable" checks like
> >     NULL != foo
> > and
> >     0 < bar
> > 
> > should probably be a separate test.
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > +                           if ($comp eq "<") {
> > +                                   $newcomp = ">=";
> > +                           } elsif ($comp eq "<=") {
> > +                                   $newcomp = ">";
> > +                           } elsif ($comp eq ">") {
> > +                                   $newcomp = "<=";
> > +                           } elsif ($comp eq ">=") {
> > +                                   $newcomp = "<";
> > +                           }
> 
> I like the concept but are you sure about this?
> I think the "=" should be added or removed. If a < b, b > a, not b >= a.

Right thanks, it's obviously incorrect.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to