On Mon, Jul 27, 2015 at 12:26 PM, Andy Lutomirski <l...@amacapital.net> wrote: > On Mon, Jul 27, 2015 at 12:19 PM, Denys Vlasenko <dvlas...@redhat.com> wrote: >> On 07/24/2015 07:50 PM, Andy Lutomirski wrote: >>> On Fri, Jul 24, 2015 at 6:47 AM, Denys Vlasenko <dvlas...@redhat.com> wrote: >>>> SYSCALL32 code is nearly identical to SYSCALL32, except for initial >>>> section. Merge them. >>>> >>>> The removal is split into two parts, to make review eaiser. This is part 1. >>>> >>>> auditsys_entry_common and auditsys_exit macros are indented one more tab >>>> without >>>> any changes. This prevents diff from becoming unreadable. >>>> They will be removed in part 2. >>> >>> I need to read these more closely, which is, at present, exceeding my >>> ability to look at asm. (See the big NMI thread.) I'll look soon. >>> >>> Meanwhile, this code is incredibly fragile wrt syscall restart. >>> (Syscall restart on compat is really weird.) Do we have a decent test >>> for it? >> >> How about this? (Feel free to expand, this is a first cut only). > > On a very brief glance, it looks reasonable, but I'd try it with > recvfrom instead of recv because it's a six-argument syscall. >
I was wondering how syscall restart works on compat syscalls on AMD (i.e. SYSCALL32). I think the answer is that it doesn't. Sigh. (Tested with ptrace instead of actual syscall restart.) --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
