On 20-08-15, 15:26, Arnd Bergmann wrote: > The use of IS_ERR_OR_NULL is almost always a bug (as is the open-coded > equivalent). > Please try to find out why this is done here and add a comment > if it's actually correct, or fix it if not. > > My guess is that it is not ok to pass an error pointer as the argument > of _regulator_put(), so maybe there should be WARN_ON()?
I agree, but updating that would require a revisit of all the API users, in case they are passing a possible error value to it. I am fine at attempting to fix that, but would need an Ack from Mark first. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
