Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 9/4/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > On Sun, Sep 04, 2005 at 12:12:18PM +0200, Harald Welte wrote: > > > Hi! > > > > > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA > > > Smartcard Reader. > > > > Sorry, the patch was missing a "cg-add" of the header file. Please use > > the patch below. > > It would be so much nicer if the patch actually was "below" - that is > "inline in the email as opposed to as an attachment". Having to first > save an attachment and then cut'n'paste from it is a pain. > > Anyway, a few comments below :
[...] > + unsigned long ulBytesToRead; > > > lowercase prefered also for variables. Also, "encoding" the type (ul) into the variable name is nonsense. [...] > + ulMin = (count < (ulBytesToRead+5))?count:(ulBytesToRead+5); Again. -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
