On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
> get_cpu_topology() tries to get topology info from all cpus by reading
> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
> have topology dir, this function fails and returns -1. This causes
> functions relying on get_cpu_topology() to fail. For example-
>
> $ cpupower monitor
> Cannot read number of available processors
>
> Fix this by skipping fetching topology info for offline cpus.
Looks fine.
Thanks!
Acked-by: Thomas Renninger <tr...@suse.de>
>
> Signed-off-by: Shreyas B. Prabhu <shre...@linux.vnet.ibm.com>
> Reported-by: Pavaman Subramaniyam <pavsu...@linux.vnet.ibm.com>
> ---
> tools/power/cpupower/utils/helpers/topology.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/power/cpupower/utils/helpers/topology.c
> b/tools/power/cpupower/utils/helpers/topology.c index
> c13120af519b..cea398c176e7 100644
> --- a/tools/power/cpupower/utils/helpers/topology.c
> +++ b/tools/power/cpupower/utils/helpers/topology.c
> @@ -73,6 +73,8 @@ int get_cpu_topology(struct cpupower_topology *cpu_top)
> for (cpu = 0; cpu < cpus; cpu++) {
> cpu_top->core_info[cpu].cpu = cpu;
> cpu_top->core_info[cpu].is_online = sysfs_is_cpu_online(cpu);
> + if (!cpu_top->core_info[cpu].is_online)
> + continue;
> if(sysfs_topology_read_file(
> cpu,
> "physical_package_id",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
