On Tue, Jun 09, 2015 at 05:05:21PM +0800, Chen Lin Z wrote:
> if register two bus with the same name, kset_register will fail.
> it need free kobject.name, otherwise there is a memory leak.
>
> Signed-off-by: Chen Lin Z <lin.z.c...@intel.com>
> ---
> drivers/base/bus.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index 79bc203..9375048 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -894,8 +894,10 @@ int bus_register(struct bus_type *bus)
> priv->drivers_autoprobe = 1;
>
> retval = kset_register(&priv->subsys);
> - if (retval)
> + if (retval) {
> + kfree(priv->subsys.kobj.name);
This doesn't solve the problem properly, as all of the other error paths
also need to free this memory.
And I really hate to poke around this "deep" into the kobject core, but
I understand it's needed here :(
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
