Hello, On Mon, Aug 03, 2015 at 07:13:29PM -0700, Guenter Roeck wrote: > The WDOG_RUNNING flag is expected to be set by watchdog drivers if > the hardware watchdog is running. If the flag is set, the watchdog > subsystem will ping the watchdog even if the watchdog device is closed. > > The watchdog driver stop function is now optional and may be omitted > if the watchdog can not be stopped. If stopping the watchdog is not > possible but the driver implements a stop function, it is responsible > to set the WDOG_RUNNING flag in its stop function. > > Cc: Timo Kokkonen <timo.kokko...@offcode.fi> > Cc: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> > Signed-off-by: Guenter Roeck <li...@roeck-us.net> > --- > Documentation/watchdog/watchdog-kernel-api.txt | 19 ++++++++----- > drivers/watchdog/watchdog_core.c | 2 +- > drivers/watchdog/watchdog_dev.c | 39 > ++++++++++++++++++++------ > include/linux/watchdog.h | 7 +++++ > 4 files changed, 50 insertions(+), 17 deletions(-) Another thing that I noticed just now after looking at a later patch in this series: Conceptually that worker stuff better fits into watchdog_core.c than watchdog_dev.c, doesn't it? But maybe this separation doesn't make sense anyhow?
Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/