On Mon, Jul 27, 2015 at 5:23 AM, Vaishali Thakkar <vthakkar1...@gmail.com> wrote:
> This patch introduces the use of devm_kzalloc and does away > with kfree in the probe function. > > Signed-off-by: Vaishali Thakkar <vthakkar1...@gmail.com> Reviewed-by: Linus Walleij <linus.wall...@linaro.org> Please get this through ARM SoC or tell me if I should handle it. > Some comments on this patch and driver: > - Here, after this change there will be a kfree on the failure of > the regmap_read too. I am not sure if driver is currently missing > it or there is something else happening here. Also, I think there > should be soc_device_unregister under the regmap_read. Likely. There are sloppy errors everywhere. > - Moreover, get_maintainer.pl is not pointing me towards any particular > mailing list or maintainers. So, I am sending this patch to all > commiters as there are only three commits for this driver. This is my code, also my stupid bugs :/ Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
