Hi Roger,
On 21/07/15 11:16, Roger Pau Monné wrote:
> El 09/07/15 a les 22.42, Julien Grall ha escrit:
>> All the usage of the field pfn are done using the same idiom:
>>
>> pfn_to_page(grant->pfn)
>>
>> This will return always the same page. Store directly the page in the
>> grant to clean up the code.
>>
>> Signed-off-by: Julien Grall <julien.gr...@citrix.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
>> Cc: Roger Pau Monné <roger....@citrix.com>
>> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com>
>> Cc: David Vrabel <david.vra...@citrix.com>
>
> Acked-by: Roger Pau Monné <roger....@citrix.com>
>
> With one style fix.
>
> [...]
>
>> static struct grant *get_grant(grant_ref_t *gref_head,
>> - unsigned long pfn,
>> + struct page *page,
>
> Indentation.
The indentation for the parameters of this function wasn't correct:
static struct grant *get_grant(grant_ref_t *gref_head,
- unsigned long pfn,
+^I^I^I struct page *page,
struct blkfront_info *info)
So "struct page *page" is correctly indent but not the remaining
parameter ("struct blkfront_info *info"). I will indent it correctly.
Regards,
--
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
