On Fri, Aug 26, 2005 at 12:06:47PM -0700, Chris Wedgwood wrote: > On Thu, Aug 25, 2005 at 09:39:15PM -0400, [EMAIL PROTECTED] wrote: > > > Wouldn't it be better to put overmount_rootfs in initramfs.c > > and call it only if there's a initramfs? > > I don't see what or how that helps. Yes we can shuffle some code > about but the real problem still exists. > > That is is that (by design) the early userspace is unpacked as soon as > possible before all kernel subsystems are up.
Overmount_rootfs shouldn't take place until you know for sure the kernel detects an initramfs. I know the patch only has one purpose and you can assume the user is using it just for that, but if the user uses the patched kernel without an initramfs it runs overmount_rootfs anyway. Also, in shmem.c init_tmpfs isn't run because it assumes that overmount_rootfs will be, so if the kernel is being used in a non initramfs way (tmpfs isn't registered). #ifndef CONFIG_EARLYUSERSPACE_ON_TMPFS module_init(init_tmpfs) #endif /* !CONFIG_EARLYUSERSPACE_ON_TMPFS */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
