On 07/04/2015 11:34 AM, Pali Rohár wrote:
> Hello,
>
> I'm looking at dell-wmi.c driver and its history in git and I found
> problem with handling WMI key code 0xe045. In current dell-wmi.c code is
>
> {KE_KEY, 0xe045, KEY_PROG1},
> {KE_IGNORE, 0xe045, KEY_NUMLOCK},
>
> I bet this is some copy-paste error as one code can be translated only
> to one input key event.
>
> In git history I found that above change was added by commit:
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5cab0098171712a9fd51399b06181c8dfdebe9c9
>
> ===============================================
> commit 5cab0098171712a9fd51399b06181c8dfdebe9c9
> Author: Mario Limonciello <mario_limoncie...@dell.com>
> Date: Wed Jun 10 19:40:47 2009 +0000
>
> dell-wmi: add additional keyboard events
>
> Upcoming Dell hardware will send more keyboard events via WMI. Add
> support for them.
>
> Signed-off-by: Mario Limonciello <mario_limoncie...@dell.com>
> Signed-off-by: Matthew Garrett <m...@redhat.com>
> Signed-off-by: Andrew Morton <a...@linux-foundation.org>
> Signed-off-by: Len Brown <len.br...@intel.com>
> ===============================================
>
> Sending email to all signers of this commit. Problematic code is still
> in upstream kernel, so it needs to be fixed.
>
> Mario Limonciello: Do you know if code 0xe045 is some PROG1 or NUMLOCK?
>
Hi Pali,
Yes this looks like a mistake and that the KEY_PROG1 item should have
been removed in that patch. It should be a notification (KEY_IGNORE)
for numlock.
Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
