> In that case if I do umount after device has gone away, I can see above > WARN(). And it does seem to be coming from. > > WARN_ON_ONCE(write_inode_now(inode, true)) > > If we failed to write back inode, then warning about it sounds right?
WARN() is for detecting kernel internal consistency problems, like potential bugs. It's not for handling IO errors or really everything that can happen on a non buggy kernel. > What's wrong with that? Should it be just a kernel log of level KERN_WARN > instead? Yes. Something like that. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
