On Sun, 14 Jun 2015, Andi Kleen wrote:
> @@ -1287,27 +1289,17 @@ static void __init uncore_cpumask_init(void)
>
> static int __init intel_uncore_init(void)
> {
> - int ret;
> -
> if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> return -ENODEV;
>
> if (cpu_has_hypervisor)
> return -ENODEV;
>
> - ret = uncore_pci_init();
> - if (ret)
> - goto fail;
> - ret = uncore_cpu_init();
> - if (ret) {
> - uncore_pci_exit();
> - goto fail;
> - }
> + uncore_pci_init();
> + uncore_cpu_init();
> uncore_cpumask_init();
So, even if the cpu does not support that, we install a completely
useless cpu notifier and invoke equally pointless init code on all
cores.
Sigh,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
