On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote:
> Some drivers implement only pause operation (no resuming). Example is
> pl330 where pause is needed for getting residuum. pl330 does not support
> resume operation, transfer must be stopped after pause.
>
> However for slaves this is exposed always as "pause and resume" which
> introduces subtle errors on Odroid U3 board (Exynos4412 with pl330).
> After adding pause function to pl330 driver the audio playback
> (utilizing DMA) gets choppy after some time (approximately 24 hours).
>
> Fix this by exposing "cmd_pause" if and only if pause and resume are
> implemented.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com>
> Reported-by: gabr...@unseen.is
> Reported-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Cc: <sta...@vger.kernel.org>
> Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature")That looks reasonable. Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com> Thanks! (and sorry for that) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
