Sudip Mukherjee писал 03.06.2015 09:15:
> On Tue, Jun 02, 2015 at 07:00:39PM +0300, Andrew Andrianov wrote:
>> From: Andrew 'Necromant' Andrianov <and...@ncrmnt.org>
>>
>> This patch adds a generic ion driver that allows
>> ion heaps to be added via devicetree. It provides
>> a simple and generic way to feed physical memory regions
>> to ion without writing a custom driver, e.g.
>>
>> ion_sram: ion@0x00100000 {
>> compatible = "ion,physmem";
>> reg = <0x00100000 0x40000>;
>> reg-names = "memory";
>> ion-heap-id = <1>;
>> ion-heap-type = <ION_HEAP_TYPE_DMA>;
>> ion-heap-align = <0x10>;
>> ion-heap-name = "SRAM";
>> };
>>
>> Signed-off-by: Andrew Andrianov <and...@ncrmnt.org>
>
> Your From: name and Signed-off-by: name is not matching.
Fixed, it's been due to different setups on my home
and work PCs. I'm still playing with proper email setup for
LKML.
> But why you are using this extra From: line? you email header From:
> is same as your Signed-off-by.
> And since you are adding new files it would be better if you can fix
> few checkpatch warnings it has. like:
>
> CHECK: Prefer kzalloc(sizeof(*ipdev)...) over kzalloc(sizeof(struct
> physmem_ion_dev)...)
> CHECK: Alignment should match open parenthesis
> CHECK: No space is necessary after a cast
> CHECK: Please don't use multiple blank lines
> regards
> sudip
I've ran checkpatch again, now with --strict, everything should be
clean now. Thanks for your comments.
Andrew Andrianov (2):
staging: ion: Add generic ion-physmem driver
staging: ion: Add ion-physmem documentation
Documentation/devicetree/bindings/ion,physmem.txt | 98 +++++++++
drivers/staging/android/ion/Kconfig | 7 +
drivers/staging/android/ion/Makefile | 5 +-
drivers/staging/android/ion/ion_physmem.c | 229 ++++++++++++++++++++++
include/dt-bindings/ion,physmem.h | 17 ++
5 files changed, 354 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/ion,physmem.txt
create mode 100644 drivers/staging/android/ion/ion_physmem.c
create mode 100644 include/dt-bindings/ion,physmem.h
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
