On (05/22/15 11:12), Marcin Jabrzyk wrote:
> >
> >no.
> >
> >zram already complains about failed comp backend creation.
> >it's in dmesg (or syslog, etc.):
> >
> > "zram: Cannot initialise %s compressing backend"
> >
> OK, now I see that. Sorry for the noise.
>
> >second, there is not much value in exposing zcomp internals,
> >especially when the result is just another line in dmesg output.
>
> From the other hand, the only valid values that can be written are
> in 'comp_algorithm'.
> So when writing other one, returning -EINVAL seems to be reasonable.
> The user would get immediately information that he can't do that,
> now the information can be very deferred in time.
it's not.
the error message appears in syslog right before we return -EINVAL
back to user.
-ss
> I'm not for exposing more internals, but getting -EINVAL would be nice I
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
