Hello Marcelo, LKML.

Attached patch fix this whatings from gcc-3.4 and allow user mount
isofs with "session" and "sbsector" options. Without this patch, gcc-3.4
optimizer always return zero.

--- cut ---
inode.c: In function `parse_options':
inode.c:341: warning: comparison of unsigned expression < 0 is always false
inode.c:347: warning: comparison of unsigned expression < 0 is always false
--- cut ---

Signed-of-by: Andrey Melnikoff <[EMAIL PROTECTED]>

--- linux-2.4.31/fs/isofs/inode.c~old   2005-08-10 16:18:48.000000000 +0400
+++ linux-2.4.31/fs/isofs/inode.c       2005-08-10 16:19:11.000000000 +0400
@@ -337,13 +337,13 @@
                }
                if (!strcmp(this_char,"session") && value) {
                        char * vpnt = value;
-                       unsigned int ivalue = simple_strtoul(vpnt, &vpnt, 0);
+                       int ivalue = simple_strtoul(vpnt, &vpnt, 0);
                        if(ivalue < 0 || ivalue >99) return 0;
                        popt->session=ivalue+1;
                }
                if (!strcmp(this_char,"sbsector") && value) {
                        char * vpnt = value;
-                       unsigned int ivalue = simple_strtoul(vpnt, &vpnt, 0);
+                       int ivalue = simple_strtoul(vpnt, &vpnt, 0);
                        if(ivalue < 0 || ivalue >660*512) return 0;
                        popt->sbsector=ivalue;
                }

-- 
 Best regards, TEMHOTA-RIPN aka MJA13-RIPE
 System Administrator. mailto:[EMAIL PROTECTED]

--- linux-2.4.31/fs/isofs/inode.c~old   2005-08-10 16:18:48.000000000 +0400
+++ linux-2.4.31/fs/isofs/inode.c       2005-08-10 16:19:11.000000000 +0400
@@ -337,13 +337,13 @@
                }
                if (!strcmp(this_char,"session") && value) {
                        char * vpnt = value;
-                       unsigned int ivalue = simple_strtoul(vpnt, &vpnt, 0);
+                       int ivalue = simple_strtoul(vpnt, &vpnt, 0);
                        if(ivalue < 0 || ivalue >99) return 0;
                        popt->session=ivalue+1;
                }
                if (!strcmp(this_char,"sbsector") && value) {
                        char * vpnt = value;
-                       unsigned int ivalue = simple_strtoul(vpnt, &vpnt, 0);
+                       int ivalue = simple_strtoul(vpnt, &vpnt, 0);
                        if(ivalue < 0 || ivalue >660*512) return 0;
                        popt->sbsector=ivalue;
                }

Reply via email to