EP-AA9D1F29B02341529D96C06444D8471D Hi Vinod >On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote: >> EP-AA9D1F29B02341529D96C06444D8471D >Whats this, please sned patch ina proper format, git format-patch is your >friend, use it >
This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback. >> >> Hi, >> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check >> of pch pointer >patch title doesn't match expectations, use the right subsystem name, and >also please explain why yoy are doing this Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git, But i think editor does some malfunctioning. >> >> Signed-off-by: Maninder Singh <[email protected]> >> Reviewed-By: Vaneet Narang <[email protected]> >> --- >> drivers/dma/pl330.c | 4 +++- ---cut--- >> Thanks >> Maninder Singh >Nice signature! > >-- >~Vinod From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001 From: Maninder Singh <[email protected]> Date: Mon, 18 May 2015 17:53:11 +0530 Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning: warn: variable dereferenced before check 'pch' So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch. Signed-off-by: Maninder Singh <[email protected]> Reviewed-by: Vaneet Narang <[email protected]> --- drivers/dma/pl330.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index a7d9d30..7e27144 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst, { struct dma_pl330_desc *desc; struct dma_pl330_chan *pch = to_pchan(chan); - struct pl330_dmac *pl330 = pch->dmac; + struct pl330_dmac *pl330; int burst; if (unlikely(!pch || !len)) return NULL; + pl330 = pch->dmac; + desc = __pl330_prep_dma_memcpy(pch, dst, src, len); if (!desc) return NULL; -- 1.7.1 Thanks Maninder ............ N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü¨}©ž²Æ zÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~††Ûiÿûàz¹ ®w¥¢¸?™¨èÚ&¢)ߢf”ù^jÇ«y§m…á@A«a¶Úÿ 0¶ìh®å’i
