On Thu, 21 May 2015, Feng Wu wrote:
> +static int intel_ir_set_vcpu_affinity(struct irq_data *data, void *vcpu_info)
> +{
> + struct intel_ir_data *ir_data = data->chip_data;
> + struct irte *irte_pi = &ir_data->irte_pi_entry;
> + struct vcpu_data *vcpu_pi_info;
> +
> + /* stop posting interrupts, back to remapping mode */
> + if (!vcpu_info)
> + modify_irte(&ir_data->irq_2_iommu, &ir_data->irte_entry);
> + else {
We add braces to both branches if one requires it.
> + vcpu_pi_info = (struct vcpu_data *)vcpu_info;
> + memcpy(irte_pi, &ir_data->irte_entry, sizeof(struct irte));
This lacks a comment WHY you copy irte_entry to irte_pi_entry and WHY
we have two seperate entries stored in ir_data.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
