On Sun, May 17, 2015 at 10:23:36PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, May 18, 2015 at 09:30:55AM +0900, Namhyung Kim escreveu:
> > This makes thread mg sharing test failed due to not decrement
> > thread->refcnt on thread__put().
>
> I fixed this one already:
>
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=8b00f46951bed1edd9c5cb9d9adb62d28bbe7623
>
> No?
I meant that I added this patch not to segfault caused by the thread
refcount, but as a side-effect it makes thread_mg_sharing test failed
due to non-decremented refcount.
As of 70923bd26c73 ("perf tools: Make flex/bison calls honour V=1")
I can reproduce the segfault.
Thanks,
Namhyung
>
> > Not-signed-off-by: Namhyung Kim <namhy...@kernel.org>
> > ---
> > tools/perf/util/thread.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> > index 702f12dc5a90..dc5ec9a5cca1 100644
> > --- a/tools/perf/util/thread.c
> > +++ b/tools/perf/util/thread.c
> > @@ -163,7 +163,7 @@ struct thread *thread__get(struct thread *thread)
> >
> > void thread__put(struct thread *thread)
> > {
> > - if (thread && atomic_dec_and_test(&thread->refcnt)) {
> > + if (thread && atomic_dec_and_test(&thread->refcnt) && 0) {
> > if (!RB_EMPTY_NODE(&thread->rb_node)) {
> > struct machine *machine = thread->mg->machine;
> >
> > --
> > 2.4.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
