Hi Greg, > No spaces after ( or before ) please. You do this all over the place in > the code, please fix it up. > > > + if (NULL == dev || NULL == driver) { > > Put the variable on the left side, gcc will complain if you incorrectly > put a "=" instead of a "==" here, which is all that you are defending > against with this style.
I think in this case the preferred way is if (!dev || !driver) { Regards Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/