On Thu, May 14, 2015 at 08:56:15PM +0800, He Kuang wrote: SNIP
> >>It seems new targets are needed. In the v2 patch, > > > >hum, I dont get it.. why ? > > > >dynamic-list-file gets rebuilt any time plugins are rebuilt.. > >why not keep just the 'plugins' dependency? > > You can test your patch as following steps: > > $ touch ../lib/traceevent/plugin_function.c > $ make > CC plugin_function.o > LD plugin_function-in.o > LINK plugin_function.so > GEN libtraceevent-dynamic-list > > perf is not rebuilt. There should be a 'GEN perf', right? hum, right.. so this is separated bug that was there even without your change. I tried to kick my change to address that and ended up with what you sent in v2 ;-) I have another comment for your v2, which I'll send right away thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/