hi,
        yes, we can't guarantee MXT_FW_RESET_TIME is enough. patch v3 is sent 
out :)
thanks
xinhui

On 2015年05月14日 19:31, Nick Dyer wrote:
Hi-

This looks like a good tidy up, one minor comment:

On 15/05/15 12:19, Pan Xinhui wrote:
+    mxt_wait_for_completion(data, &data->fw_load_completion,
+                    MXT_FW_RESET_TIME);

this should probably just be

wait_for_completion(&data->fw_load_completion);

rather than timing out (the MXT_FW_RESET_TIME may not be an appropriate
length anyway)

cheers

Nick

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to