On Mon, 2015-05-11 at 15:04 -0700, Josh Triplett wrote: > On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: > > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > > +config KALLSYMS_ALL > > > + bool "Include all symbols in kallsyms" > > > > (For some reason this entry doesn't have if EXPERT but it seems to > > behave as expected. Odd.) > > Because it depends on KALLSYMS. Magic!
Welcome to the land of Kconfig! > > > + depends on DEBUG_KERNEL && KALLSYMS > > > + help > > > + Normally kallsyms only contains the symbols of functions for nicer > > > + OOPS messages and backtraces (i.e., symbols from the text and > > > inittext > > > + sections). This is sufficient for most cases. And only in very rare > > > + cases (e.g., when a debugger is used) all symbols are required (e.g., > > > + names of variables from the data sections, etc). > > > + > > > + This option makes sure that all symbols are loaded into the kernel > > > + image (i.e., symbols from all sections) in cost of increased kernel > > > + size (depending on the kernel configuration, it may be 300KiB or > > > + something like this). > > > + > > > + Say N unless you really need all symbols. > > > + > > > +config PRINTK > > > + default y > > > + bool "Enable support for printk" if EXPERT > > > > Now you're touching this: bool [...] as the first line, please. > > I'd like the commit moving these to their own file to very obviously > look like it's moving these lines unmodified, rather than making changes > in the process. If you want this (and all the subsequent instances you > flagged) cleaned up, let's do that as a subsequent patch separate from > the move. That was one of my pet peeves leaving it's cage. Still, not sure if we'd really notice if it's not a simple move. But a separate patch would mainly add noise, so let's not do that. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
