On 8/5/05, Oliver Neukum <[EMAIL PROTECTED]> wrote: > Am Freitag, 5. August 2005 20:14 schrieb Jon Smirl: > > On 8/5/05, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > > Am Freitag, 5. August 2005 15:32 schrieb Jon Smirl: > > > > On 1/1/02, Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > > Hi! > > > > > > > > > > > > > New, simplified version of the sysfs whitespace strip patch... > > > > > > > > > > > > > > Could you tell me why you don't just fail the operation if > > > > > > > malformed > > > > > > > input is supplied? > > > > > > > > > > > > Leading/trailing white space should be allowed. For example echo > > > > > > appends '\n' unless you know to use -n. It is easier to fix the > > > > > > kernel > > > > > > than to teach everyone to use -n. > > > > > > > > > > Please, NO! echo -n is the right thing to do, and users will > > > > > eventually learn. > > > > > We are not going to add such workarounds all over the kernel... > > > > > > > > It is not a work around. These are text attributes meant for human > > > > use. Humans have a hard time cleaning up things they can't see. And > > > > the failure mode for this is awful, your attribute won't set but > > > > everything on the screen looks fine. > > > > > > The average user has no place poking sysfs. Root should know when > > > to use -n, as should shell scripts. > > > > So the average user never needs to change their console mode? Check > > out /sys/class/graphics/fb/modes and mode. > > That is what we have helper scripts for.
If we are going back to needing helper scripts then I should just remove the entire sysfs graphics interface and switch back to using ioctls and a helper app. Of could no one can ever find the helper app or remember how it works. I thought one of the main reasons behind the sysfs interface was to eliminate these helper apps. Without doing whitespace cleanup there is a 100% probability that this will generate bug reports. I know this for a fact because I am already getting them. -- Jon Smirl [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
