On Wed, 29 Apr 2015 21:28:38 +0530 Shreyas B Prabhu <shre...@linux.vnet.ibm.com> wrote:
> > > On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote: > > On Wed, 29 Apr 2015 20:19:28 +0530 > > Shreyas B Prabhu <shre...@linux.vnet.ibm.com> wrote: > > > >> IIUC there is no existing macro which can both add a condition and > >> override printk format, hence the fall back to TRACE_EVENT_CONDITION. > > > > Hmm, want me to send you a patch that changes that? > > > I am not sure if its worth the effort now. It doesn't look like any > other trace point apart from the above use case will benefit from it. > Only smbus_write and smbus_reply seem to come close. But even they need > separate TP_fast_assign. It shouldn't be a problem to implement. But I'm currently cleaning up those files, and any changes will cause nasty conflicts. Lets do this. Push the current changes as is, and when I get around to adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use it. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
