Hello Paul,
Thanks for feedback :).
I understand. I will change the license to GPL.
Thanks,
Anda
________________________________________
From: Paul Bolle [pebo...@tiscali.nl]
Sent: Saturday, April 25, 2015 12:00 PM
To: Nicolae, Anda-maria
Cc: s...@kernel.org; dbarysh...@gmail.com; robh...@kernel.org;
pawel.m...@arm.com; mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk;
ga...@codeaurora.org; dw...@infradead.org; linux...@vger.kernel.org;
linux-kernel@vger.kernel.org; devicet...@vger.kernel.org
Subject: Re: [PATCH] power_supply: Add support for Richtek rt9455 battery
charger
Just a single nit: a license mismatch.
On Fri, 2015-04-24 at 10:57 +0300, Anda-Maria Nicolae wrote:
> --- /dev/null
> +++ b/drivers/power/rt9455_charger.c
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
This states the license is GPL v2 or later.
> +MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is
(only) GPL v2. So I think either the license comment or the ident used
in the MODULE_LICENSE() macro should be changed.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
