On 20 April 2015 at 16:47, Andy Lutomirski <l...@amacapital.net> wrote: > On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.ba...@linaro.org> wrote: >> On 20 April 2015 at 16:22, Andy Lutomirski <l...@amacapital.net> wrote: >>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.ba...@linaro.org> wrote: >>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64. >>>> >>>> Cc: Andy Lutomirski <l...@amacapital.net> >>>> Signed-off-by: Tyler Baker <tyler.ba...@linaro.org> >>>> --- >>>> tools/testing/selftests/x86/Makefile | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/x86/Makefile >>>> b/tools/testing/selftests/x86/Makefile >>>> index be93945..a5ca38b 100644 >>>> --- a/tools/testing/selftests/x86/Makefile >>>> +++ b/tools/testing/selftests/x86/Makefile >>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) >>>> >>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall >>>> >>>> +all: >>>> + >>> >>> This... >>> >>>> UNAME_M := $(shell uname -m) >>>> >>>> +ifeq ($(CROSS_COMPILE),) >>>> # Always build 32-bit tests >>>> all: all_32 >>>> - >>>> # If we're on a 64-bit host, build 64-bit tests as well >>>> ifeq ($(UNAME_M),x86_64) >>>> all: all_64 >>>> endif >>>> +else >>>> +# No dependency on all when cross building >>>> +all: >>> >>> ...is redundant with this. If you delete the "else" and "all:" here, then: >> >> Ok, I will remove these bits from this patch. However, the else will >> need to be added back in the next patch of the series to override the >> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok >> with that. > > I'm fine with that, unless you or Shuah want to fix lib.mk.
I will send a follow up series to address this issue. > > --Andy Tyler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
