Hi Wolfram,
On Tue, Mar 24, 2015 at 01:38:09PM +0100, Wolfram Sang wrote:
>
> > for (i = 0; i < pdata->num_subdevs; i++) {
> > - if (!pdata->subdevs[i].platform_data)
> > + if (!pdata->subdevs[i].platform_data) {
> > + dev_err(dev, "No data for %d regulator\n", i);
> > return -EINVAL;
> > + }
>
> I'd rather save the string and go for -ENOENT instead. But I don't mind
> much...I think -ENOENT doesn't describe it enough. For example if pdata is parsed from DT, this may as well be a missing regulator node in the devicetree. Best Regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature
