On Mon, Mar 23, 2015 at 12:37 PM, Andy Lutomirski <l...@amacapital.net> wrote: > On Mon, Mar 23, 2015 at 9:47 AM, Denys Vlasenko <dvlas...@redhat.com> wrote: >> This vDSO code only gets used by 64-bit kernel, >> not 32-bit. In 64-bit kernels, data segment is the same >> for 32-bit and 64-bit userspace, and SYSRET insn does load %ss >> with its selector. No need to repeat it by hand. Segment loads >> are somewhat expensive: tens of cycles. >> >> Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> >> CC: Linus Torvalds <torva...@linux-foundation.org> >> CC: Steven Rostedt <rost...@goodmis.org> >> CC: Ingo Molnar <mi...@kernel.org> >> CC: Borislav Petkov <b...@alien8.de> >> CC: "H. Peter Anvin" <h...@zytor.com> >> CC: Andy Lutomirski <l...@amacapital.net> >> CC: Oleg Nesterov <o...@redhat.com> >> CC: Frederic Weisbecker <fweis...@gmail.com> >> CC: Alexei Starovoitov <a...@plumgrid.com> >> CC: Will Drewry <w...@chromium.org> >> CC: Kees Cook <keesc...@chromium.org> >> CC: x...@kernel.org >> CC: linux-kernel@vger.kernel.org >> --- >> >> Patch was run-tested. > > Applied, thanks.
Actually, I want to remove the added comment in the code. I don't see why we should have a specific comment about SS and not about, say, CS, ESP, or anything else. OK? > > --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/