Hi Yijing, On Mon, Mar 23, 2015 at 1:08 PM, kbuild test robot <fengguang...@intel.com> wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > pci/enumeration-yw7 > head: 2681a1f3d2011d4cbb888d3e974a13bda85d225c > commit: 2577ed41b6a6db3117713069e49b72091b60c867 [32/35] PCI: rename to > pci_find_host_bridge() > reproduce: > # apt-get install sparse > git checkout 2577ed41b6a6db3117713069e49b72091b60c867 > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was >>> not declared. Should it be static? > > Please review and possibly fold the followup patch.
It does look like pci_find_host_bridge() is only used inside drivers/pci/host-bridge.c and could be static. Given that it's only used there, it doesn't even need to be renamed, so maybe you could even just drop the rename patch, too. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
