When xattr name (key) is empty (""), correctly return -EINVAL
error. xattr_advise_set/get() seem to make the same mistake.
Signed-off-by: Taesoo Kim <tsgat...@gmail.com>
---
fs/f2fs/xattr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
index 5072bf9..6b1fbc4 100644
--- a/fs/f2fs/xattr.c
+++ b/fs/f2fs/xattr.c
@@ -132,7 +132,7 @@ static int f2fs_xattr_advise_get(struct dentry *dentry,
const char *name,
{
struct inode *inode = dentry->d_inode;
- if (strcmp(name, "") != 0)
+ if (strcmp(name, "") == 0)
return -EINVAL;
*((char *)buffer) = F2FS_I(inode)->i_advise;
@@ -144,7 +144,7 @@ static int f2fs_xattr_advise_set(struct dentry *dentry,
const char *name,
{
struct inode *inode = dentry->d_inode;
- if (strcmp(name, "") != 0)
+ if (strcmp(name, "") == 0)
return -EINVAL;
if (!inode_owner_or_capable(inode))
return -EPERM;
--
2.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
