Commit-ID: f4c3686386393c120710dd34df2a74183ab805fd Gitweb: http://git.kernel.org/tip/f4c3686386393c120710dd34df2a74183ab805fd Author: Oleg Nesterov <o...@redhat.com> AuthorDate: Fri, 13 Mar 2015 09:53:10 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Fri, 13 Mar 2015 12:44:29 +0100
x86/fpu: Drop_fpu() should not assume that tsk equals current drop_fpu() does clear_used_math() and usually this is correct because tsk == current. However switch_fpu_finish()->restore_fpu_checking() is called before __switch_to() updates the "current_task" variable. If it fails, we will wrongly clear the PF_USED_MATH flag of the previous task. So use clear_stopped_child_used_math() instead. Signed-off-by: Oleg Nesterov <o...@redhat.com> Signed-off-by: Borislav Petkov <b...@suse.de> Reviewed-by: Rik van Riel <r...@redhat.com> Cc: <sta...@vger.kernel.org> Cc: Andy Lutomirski <l...@amacapital.net> Cc: Borislav Petkov <b...@alien8.de> Cc: Dave Hansen <dave.han...@intel.com> Cc: Fenghua Yu <fenghua...@intel.com> Cc: H. Peter Anvin <h...@zytor.com> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Pekka Riikonen <priik...@iki.fi> Cc: Quentin Casasnovas <quentin.casasno...@oracle.com> Cc: Suresh Siddha <sbsid...@gmail.com> Cc: Thomas Gleixner <t...@linutronix.de> Link: http://lkml.kernel.org/r/20150309171041.gb11...@redhat.com Signed-off-by: Ingo Molnar <mi...@kernel.org> --- arch/x86/include/asm/fpu-internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/fpu-internal.h b/arch/x86/include/asm/fpu-internal.h index 0dbc082..72ba21a 100644 --- a/arch/x86/include/asm/fpu-internal.h +++ b/arch/x86/include/asm/fpu-internal.h @@ -370,7 +370,7 @@ static inline void drop_fpu(struct task_struct *tsk) preempt_disable(); tsk->thread.fpu_counter = 0; __drop_fpu(tsk); - clear_used_math(); + clear_stopped_child_used_math(tsk); preempt_enable(); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
