On Wed, Mar 11, 2015 at 04:16:30PM +1100, Aleksa Sarai wrote: > We know that the task will have its css_set set to task_css_set(current), and > we could just use that in cgroup_can_fork(). The only question is, can > task_css_set(current) change between cgroup_can_fork() and cgroup_post_fork()?
Yes, that's what I've been writing in the previous messages. It can change. > If it can change between the two calls, then we're in trouble -- there'd be no > reliable way of checking that the future css_set allows for the fork without > going through the registration of the css_set *proper* in cgroup_post_fork() > unless we hold css_set_rwsem for the entirety of the can_fork() to post_fork() > segment (which I can't imagine is a good idea). Please re-read my previous messages. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
