On Tue, 2015-03-03 at 15:02 -0500, David Miller wrote: > From: Randy Dunlap <rdun...@infradead.org> > Date: Tue, 03 Mar 2015 11:35:38 -0800 > > > From: Randy Dunlap <rdun...@infradead.org> > > > > i40e uses configfs interfaces so it should depend on CONFIGFS_FS. > > > > Fixes these build errors: > > > > drivers/built-in.o: In function `i40e_cfgfs_group_make_item': > > i40e_configfs.c:(.text+0x2fcdca): undefined reference to > > `config_item_init_type_name' > > drivers/built-in.o: In function `i40e_configfs_init': > > (.text+0x2fcee6): undefined reference to `config_group_init' > > drivers/built-in.o: In function `i40e_configfs_init': > > (.text+0x2fcf0c): undefined reference to `configfs_register_subsystem' > > drivers/built-in.o: In function `i40e_configfs_exit': > > (.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem' > > > > Signed-off-by: Randy Dunlap <rdun...@infradead.org> > > Intel guys, I am furiously mad. > > I've told you guys a thousand times to use portable, reasonable > mechanisms to configure your hardware. Using facilities that can > be used for other cards from other vendors with similar facilities. > > If such portable netdevice configuration frameworks do not exist, > create it. > > Every time you make a device specific mechanism for configuration, > a small kitten dies somewhere in the world. > > Please remove all of this configfs crap for twiddling bandwidth > et al. knobs, before I do it for you.
Sorry Dave, I did not see the configfs changes as being in the same boat as some of the debugfs changes which were unacceptable. I am working with Greg Rose and Jesse Brandeburg to address your concerns with these recent changes.
signature.asc
Description: This is a digitally signed message part
