On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni <alexandre.bell...@free-electrons.com> wrote:
> On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : > > On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni > > <alexandre.bell...@free-electrons.com> wrote: > > > > > Add support for the i2c RTC from Abracon. > > > > What is the relationship between this patch and > > http://ozlabs.org/~akpm/mmots/broken-out/rtc-add-rtc-abx805-a-driver-for-the-abracon-ab-1805-i2c-rtc.patch? > > > > I'd say drop mine, I couldn't find the other one before writing it... > > I'll try to build on Philippe's driver. Which driver supports the most devices? Your driver has +static const struct i2c_device_id abx80x_id[] = { + { "abx80x", ABX80X }, + { "ab0801", AB0801 }, + { "ab0802", AB0802 }, + { "ab0803", AB0803 }, + { "ab0804", AB0804 }, + { "ab0805", AB0805 }, + { "ab1801", AB1801 }, + { "ab1802", AB1802 }, + { "ab1803", AB1803 }, + { "ab1804", AB1804 }, + { "ab1805", AB1805 }, + { } +}; And Philippe's has +static struct i2c_device_id abx805_id[] = { + { "abx805-rtc", 0 }, + { } +}; And is the naming in Philippe's driver appropriate? If it supports the AB1801 (for example) then why is it described as an "abx805" driver? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
