There's no point in printing error message if platform_get_irq()
returns -EPROBE_DEFER because probe deferring subsystem already outputs
message in bootlog like this:
--->8---
platform e001d000.i2c: Driver i2c_designware requests probe deferral
--->8---
Moreover in case of probe deferral following message may mislead user:
--->8---
i2c_designware e001d000.i2c: no irq resource?
--->8---
even though it's expected that platform_get_irq() may return
-EPROBE_DEFER.
Signed-off-by: Alexey Brodkin <abrod...@synopsys.com>
Cc: Vineet Gupta <vgu...@synopsys.com>
Cc: Christian Ruppert <christian.rupp...@abilis.com>
Cc: Mika Westerberg <mika.westerb...@linux.intel.com>
Cc: Wolfram Sang <w...@the-dreams.de>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
b/drivers/i2c/busses/i2c-designware-platdrv.c
index c270f5f..01c1b17 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -144,7 +144,8 @@ static int dw_i2c_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no irq resource?\n");
+ if (irq != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "no irq resource?\n");
return irq; /* -ENXIO */
}
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
